Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix cli #2350

Merged
merged 2 commits into from
Nov 22, 2017
Merged

Hotfix cli #2350

merged 2 commits into from
Nov 22, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: CLI doesn't work on alpha

See #269 (comment)

@Hypnosphi Hypnosphi requested a review from a team November 22, 2017 10:21
@Hypnosphi Hypnosphi changed the base branch from master to release/3.3 November 22, 2017 10:21
@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #2350 into release/3.3 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #2350   +/-   ##
============================================
  Coverage        22.75%   22.75%           
============================================
  Files              326      326           
  Lines             6767     6767           
  Branches           836      840    +4     
============================================
  Hits              1540     1540           
- Misses            4624     4631    +7     
+ Partials           603      596    -7
Impacted Files Coverage Δ
lib/cli/bin/index.js 0% <0%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
addons/info/src/components/Node.js 39.13% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/info/src/components/types/Signature.js 16.66% <0%> (ø) ⬆️
addons/viewport/src/components/SelectViewport.js 15% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776f3a6...45ec0ee. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (weird ;-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants